mjsax commented on code in PR #17169:
URL: https://github.com/apache/kafka/pull/17169#discussion_r1759287020
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##########
@@ -352,6 +364,33 @@ private <K, V> void handleException(final
ProductionExceptionHandler.Serializati
droppedRecordsSensor.record();
}
+ private DefaultErrorHandlerContext errorHandlerContext(final
InternalProcessorContext<Void, Void> context,
+ final String
processorNodeId) {
+ final RecordContext recordContext = context != null ?
context.recordContext() : null;
+
+ return recordContext != null ?
+ new DefaultErrorHandlerContext(
+ null, // only required to pass for
DeserializationExceptionHandler
Review Comment:
Matter of personal taste -- I personally don't like constructor overloads
too much. -- It also does not explain when you need to pass the context and
when not... only a comment can explain this.
However, we can still pass in the `context` here, too -- it won't be used,
but it won't hurt either...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
