cmccabe commented on code in PR #17192:
URL: https://github.com/apache/kafka/pull/17192#discussion_r1759340419
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -260,9 +260,6 @@ class KafkaServer(
/* generate brokerId */
config._brokerId = getOrGenerateBrokerId(initialMetaPropsEnsemble)
- // Currently, we are migrating from ZooKeeper to KRaft. If
broker.id.generation.enable is set to true,
- // we must ensure that the nodeId synchronizes with the broker.id to
prevent the nodeId from being -1,
- // which would result in a failure during the migration.
config._nodeId = config.brokerId
Review Comment:
Yes, fair point. Let's do that later since we're trying to get this specific
change into 3.9. In trunk we'll be able to make both immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
