chia7712 commented on code in PR #16965:
URL: https://github.com/apache/kafka/pull/16965#discussion_r1760275929
##########
build.gradle:
##########
@@ -119,8 +119,14 @@ ext {
addParametersForTests = { name, options ->
// -parameters generates arguments with parameter names in
TestInfo#getDisplayName.
// ref:
https://github.com/junit-team/junit5/blob/4c0dddad1b96d4a20e92a2cd583954643ac56ac0/junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTest.java#L161-L164
- if (name == "compileTestJava" || name == "compileTestScala")
+ if (name == "compileTestJava" || name == "compileTestScala") {
options.compilerArgs << "-parameters"
+ } else if (name == "compileJava") {
Review Comment:
please change `compileJava` to `compileScala` to add the args to "scala
compiler"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
