bbejeck commented on code in PR #17110:
URL: https://github.com/apache/kafka/pull/17110#discussion_r1761448327
##########
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java:
##########
@@ -145,7 +144,7 @@ private interface MetricsVerifier {
}
@ParameterizedTest
- @ValueSource(strings = {StreamsConfig.AT_LEAST_ONCE,
StreamsConfig.EXACTLY_ONCE, StreamsConfig.EXACTLY_ONCE_V2})
+ @ValueSource(strings = {StreamsConfig.AT_LEAST_ONCE,
StreamsConfig.EXACTLY_ONCE_V2})
Review Comment:
I agree we probably don't need a parameterized test here and on the
`ResetPartitionTimeIntegrationTest` above you called out, but maybe we can
address in a followup PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
