mumrah commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1763207161
########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' Review Comment: remove this one (since we have kraft below) ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' + +storage: +- changed-files: + - any-glob-to-any-file: + - 'storage/**' + +streams: +- changed-files: + - any-glob-to-any-file: + - 'streams/**' + +tests: +- changed-files: + - any-glob-to-any-file: + - 'tests/**' + +tools: +- changed-files: + - any-glob-to-any-file: + - 'tools/**' + - 'trogdor/**' + - 'vagrant/**' + - 'committer-tools/**' + +metadata: +- changed-files: + - any-glob-to-any-file: + - 'metadata/**' Review Comment: remove this one ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' + +storage: +- changed-files: + - any-glob-to-any-file: + - 'storage/**' + +streams: +- changed-files: + - any-glob-to-any-file: + - 'streams/**' + +tests: +- changed-files: + - any-glob-to-any-file: + - 'tests/**' Review Comment: remove this one ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' + +storage: +- changed-files: + - any-glob-to-any-file: + - 'storage/**' + +streams: +- changed-files: + - any-glob-to-any-file: + - 'streams/**' + +tests: +- changed-files: + - any-glob-to-any-file: + - 'tests/**' + +tools: +- changed-files: + - any-glob-to-any-file: + - 'tools/**' + - 'trogdor/**' + - 'vagrant/**' + - 'committer-tools/**' + +metadata: +- changed-files: + - any-glob-to-any-file: + - 'metadata/**' + +docs: +- changed-files: + - any-glob-to-any-file: + - 'docs/**' + - '**/*.md' + +docker: +- changed-files: + - any-glob-to-any-file: + - 'docker/**' + +server: +- changed-files: + - any-glob-to-any-file: + - '*server*/**' + +coordinator: +- changed-files: + - any-glob-to-any-file: + - '*coordinator*/**' + +examples: Review Comment: how about `docs` instead? ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' + +storage: +- changed-files: + - any-glob-to-any-file: + - 'storage/**' + +streams: +- changed-files: + - any-glob-to-any-file: + - 'streams/**' + +tests: +- changed-files: + - any-glob-to-any-file: + - 'tests/**' + +tools: +- changed-files: + - any-glob-to-any-file: + - 'tools/**' + - 'trogdor/**' + - 'vagrant/**' + - 'committer-tools/**' + +metadata: +- changed-files: + - any-glob-to-any-file: + - 'metadata/**' + +docs: +- changed-files: + - any-glob-to-any-file: + - 'docs/**' + - '**/*.md' + +docker: +- changed-files: + - any-glob-to-any-file: + - 'docker/**' + +server: +- changed-files: + - any-glob-to-any-file: + - '*server*/**' + +coordinator: +- changed-files: + - any-glob-to-any-file: + - '*coordinator*/**' + +examples: +- changed-files: + - any-glob-to-any-file: + - 'examples/**' + +benchmarks: Review Comment: let's use `performance` ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' + +storage: +- changed-files: + - any-glob-to-any-file: + - 'storage/**' + +streams: +- changed-files: + - any-glob-to-any-file: + - 'streams/**' + +tests: +- changed-files: + - any-glob-to-any-file: + - 'tests/**' + +tools: +- changed-files: + - any-glob-to-any-file: + - 'tools/**' + - 'trogdor/**' + - 'vagrant/**' + - 'committer-tools/**' + +metadata: +- changed-files: + - any-glob-to-any-file: + - 'metadata/**' + +docs: +- changed-files: + - any-glob-to-any-file: + - 'docs/**' + - '**/*.md' + +docker: +- changed-files: + - any-glob-to-any-file: + - 'docker/**' + +server: +- changed-files: + - any-glob-to-any-file: + - '*server*/**' Review Comment: combine this with `core` (we don't use `server` label) ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' + +connect: +- changed-files: + - any-glob-to-any-file: + - 'connect/**' + +core: +- changed-files: + - any-glob-to-any-file: + - 'core/**' + +raft: +- changed-files: + - any-glob-to-any-file: + - 'raft/**' + +storage: +- changed-files: + - any-glob-to-any-file: + - 'storage/**' + +streams: +- changed-files: + - any-glob-to-any-file: + - 'streams/**' + +tests: +- changed-files: + - any-glob-to-any-file: + - 'tests/**' + +tools: +- changed-files: + - any-glob-to-any-file: + - 'tools/**' + - 'trogdor/**' + - 'vagrant/**' + - 'committer-tools/**' + +metadata: +- changed-files: + - any-glob-to-any-file: + - 'metadata/**' + +docs: +- changed-files: + - any-glob-to-any-file: + - 'docs/**' + - '**/*.md' + +docker: +- changed-files: + - any-glob-to-any-file: + - 'docker/**' + +server: +- changed-files: + - any-glob-to-any-file: + - '*server*/**' + +coordinator: +- changed-files: + - any-glob-to-any-file: + - '*coordinator*/**' Review Comment: let's enumerate `coordinator-common` and `group-coordinator` here ########## .github/labeler.yml: ########## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: + - 'clients/**' + +config: +- changed-files: + - any-glob-to-any-file: + - 'config/**' Review Comment: remove this one (no `config` label) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
