mumrah commented on PR #17191: URL: https://github.com/apache/kafka/pull/17191#issuecomment-2355940548
I managed to reproduce the issue in this run https://github.com/apache/kafka/actions/runs/10893557629/job/30231419064?pr=17191 ``` 2024-09-17T01:39:47.4626128Z 2024-09-17T01:39:47.4627809Z Gradle Test Run :streams:test > Gradle Test Executor 11 > StreamThreadTest > shouldGetProducerInstanceId(boolean, boolean) > "shouldGetProducerInstanceId(boolean, boolean).stateUpdaterEnabled=true, processingThreadsEnabled=true" STARTED 2024-09-17T01:39:57.5507998Z 2024-09-17T01:39:57.5510603Z Gradle Test Run :streams:test > Gradle Test Executor 11 > StreamThreadTest > shouldGetProducerInstanceId(boolean, boolean) > "shouldGetProducerInstanceId(boolean, boolean).stateUpdaterEnabled=true, processingThreadsEnabled=true" PASSED ``` Notice the 10 second delay in this test. This is coming from the changes I have in this PR: ```java // in DefaultTaskManager public void shutdown(final Duration duration) { for (final TaskExecutor t: taskExecutors) { t.requestShutdown(); } signalTaskExecutors(); try { for (final TaskExecutor t: taskExecutors) { t.awaitShutdown(Duration.ofSeconds(10)); } } catch (final Exception e) { signalTaskExecutors(); for (final TaskExecutor t: taskExecutors) { t.awaitShutdown(duration); } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
