FrankYang0529 commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1765301371
########## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java: ########## @@ -1617,12 +1617,25 @@ public void testRevokePartitionsUsesTopicNamesLocalCacheWhenMetadataNotAvailable } @Test - public void testOnSubscriptionUpdatedTransitionsToJoiningOnlyIfNotInGroup() { + public void testOnSubscriptionUpdatedDoNothingIfInGroup() { Review Comment: Thanks for the suggestion. I think whether the member is in the group is important as well, because it determines whether to change `shouldTransitionToJoining` variable. I update the test case name to `testOnSubscriptionUpdatedDoesNotSetShouldTransitionToJoiningIfInGroup` and another test case below to `testOnSubscriptionUpdatedSetShouldTransitionToJoiningIfNotInGroup`. Do you think it makes sense? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org