jayteej opened a new pull request, #17232:
URL: https://github.com/apache/kafka/pull/17232
**Problem:**
Log cleaner supports dynamic configs for the following:
```
val ReconfigurableConfigs: Set[String] = Set(
CleanerConfig.LOG_CLEANER_THREADS_PROP,
CleanerConfig.LOG_CLEANER_DEDUPE_BUFFER_SIZE_PROP,
CleanerConfig.LOG_CLEANER_DEDUPE_BUFFER_LOAD_FACTOR_PROP,
CleanerConfig.LOG_CLEANER_IO_BUFFER_SIZE_PROP,
ServerConfigs.MESSAGE_MAX_BYTES_CONFIG,
CleanerConfig.LOG_CLEANER_IO_MAX_BYTES_PER_SECOND_PROP,
CleanerConfig.LOG_CLEANER_BACKOFF_MS_PROP
)
```
When these are modified dynamically they update as expected, however if the
broker is restarted they are not applied. Note that the dynamic config logs
correctly, it is just not applied as verified by logs/thread dump.
**What this PR does:**
This PR changes the evaluation of these configs in KafkaConfig from `val` to
`def` so that they are picked up following dynamic config initialization at
KafkaServer startup().
**Testing:**
- This issue is reproducible manually by updating a log cleaner config such
as number of threads and then restarting the broker and checking the number of
threads started in the logs.
- This issue is reproducible in the system tests (added) by restarting the
server and verifying the number of threads following a restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
