OmniaGM commented on PR #17016: URL: https://github.com/apache/kafka/pull/17016#issuecomment-2363666325
> Hi @OmniaGM - I took a pass and and found the problem. > > For the failing tests, the `EmbeddedKafkaCluster` started with time `0`; subsequently, the log cleaner would run and delete the log. If we use the constructor overload of the `EmbeddedKafkaCluster` that doesn't take a time parameter, it will initialize to the current time. The other fix for tests with low timestamp values (0, 5000, etc.) was to create a static variable with the current time and add it to the timestamp, preserving the test logic. I've [pushed a PR](https://github.com/apache/kafka/pull/17238) to demonstrate the changes for updating this one > > ~I'm still looking at one failure in the `RestoreIntegrationTest` that I think is unrelated to timestamps.~ Should be fixed now Thanks @bbejeck for spotting this, I updated the pr now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
