FrankYang0529 commented on code in PR #17244:
URL: https://github.com/apache/kafka/pull/17244#discussion_r1771374443
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1471,6 +1487,7 @@ public void unsubscribe() {
fetchBuffer.retainAll(Collections.emptySet());
Timer timer = time.timer(defaultApiTimeoutMs);
UnsubscribeEvent unsubscribeEvent = new
UnsubscribeEvent(calculateDeadlineMs(timer));
+
backgroundEventProcessor.setIgnorePreviousBackgroundErrorEvent(timer.currentTimeMs());
Review Comment:
Hi @lianetm, thanks for the review. I updated a version to ignore
`InvalidTopicException`.
I would like to check again. Do you think that we can make this function
more reusable? Like, we can let developers set ignore exception type in the
function, so if there are othere parts need to ignore something, they can just
reuse the function. Or we don't need to over-engineering at this time? Thank
you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
