smjn commented on code in PR #17262: URL: https://github.com/apache/kafka/pull/17262#discussion_r1773252360
########## share/src/main/java/org/apache/kafka/server/share/DeleteShareGroupStateParameters.java: ########## @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.kafka.server.group.share; +package org.apache.kafka.server.share; Review Comment: For the callers the main entry point is NoOpStatePersister/Persister/DefaultStatePersister. All the other classes are wrappers for the actual RPC records. Ideally callers should not be aware that there is even a coordinator. They will however need to create objects to pass parameters into and fetch results from these interfaces. The thinking behind the current structure was not to expose to the callers that there is a specific handler/share coordinator which these interfaces delegate the call to. We followed similar approach in coordinator-common where we just kept one package for Records/metrics/runtime etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
