CalvinConfluent commented on code in PR #17265:
URL: https://github.com/apache/kafka/pull/17265#discussion_r1776014436
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -148,28 +150,36 @@ public class TransactionManagerTest {
private Sender sender = null;
private TransactionManager transactionManager = null;
private Node brokerNode = null;
+ private long finalizedFeaturesEpoch = 0;
@BeforeEach
public void setup() {
this.metadata.add("test", time.milliseconds());
this.client.updateMetadata(RequestTestUtils.metadataUpdateWith(1,
singletonMap("test", 2)));
this.brokerNode = new Node(0, "localhost", 2211);
- initializeTransactionManager(Optional.of(transactionalId));
+ initializeTransactionManager(Optional.of(transactionalId), false);
}
- private void initializeTransactionManager(Optional<String>
transactionalId) {
+ private void initializeTransactionManager(Optional<String>
transactionalId, boolean transactionV2Enabled) {
Metrics metrics = new Metrics(time);
- apiVersions.update("0", NodeApiVersions.create(Arrays.asList(
- new ApiVersion()
- .setApiKey(ApiKeys.INIT_PRODUCER_ID.id)
- .setMinVersion((short) 0)
- .setMaxVersion((short) 3),
- new ApiVersion()
Review Comment:
Good catch. Surprisingly it does not break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
