chia7712 commented on code in PR #17284:
URL: https://github.com/apache/kafka/pull/17284#discussion_r1777621182


##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##########
@@ -79,9 +75,7 @@ private ConsumerGroupCommandTestUtils() {
     }
 
     static List<ClusterConfig> generator() {
-        return Stream
-            .concat(forKRaftGroupCoordinator().stream(), 
forZkGroupCoordinator().stream())
-            .collect(Collectors.toList());
+        return new ArrayList<>(forKRaftGroupCoordinator());
     }
 
     static List<ClusterConfig> forKRaftGroupCoordinator() {

Review Comment:
   Could you please inline `forKRaftGroupCoordinator` to `generator`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to