chia7712 commented on code in PR #17299:
URL: https://github.com/apache/kafka/pull/17299#discussion_r1779097973
##########
.github/actions/gh-api-update-check/action.yml:
##########
@@ -39,23 +39,43 @@ inputs:
description: "The text to display next to the check"
default: ""
required: false
- context:
- description: "The name of the status check"
+ title:
+ description: "The title of the status check"
required: true
- state:
- description: "The state of the check. Can be one of: error, failure,
pending, success"
+ status:
+ description: "The status of the check. Can be one of: queued, in_progress,
completed, waiting, requested, pending"
required: true
+ conclusion:
+ description: "Required if status is 'completed'. Can be one of:
action_required, cancelled, failure, neutral, success, skipped, stale,
timed_out"
+ required: false
runs:
using: "composite"
steps:
- - name: Update Check
+ - if: inputs.conclusion == ''
Review Comment:
Pardon me, what is the purpose of this step?
##########
.github/workflows/build.yml:
##########
@@ -39,11 +39,21 @@ jobs:
matrix:
java: [ 21, 17, 11, 8 ]
name: Compile and Check Java ${{ matrix.java }}
+ outputs:
+ is-draft: ${{ steps.check-draft-pr.outputs.is-draft }}
steps:
- name: Env
run: printenv
env:
GITHUB_CONTEXT: ${{ toJson(github) }}
+ - name: Check for Draft PR
+ id: check-draft-pr
+ if: |
+ github.event_name == 'pull_request' && (
+ github.event.pull_request.draft ||
+ contains(github.event.pull_request.title, 'WIP')
Review Comment:
In my opinion, using the "title" to indicate that a PR doesn't need CI is
less straightforward than simply marking it as a "draft." Perhaps a WIP could
be interpreted as "this PR requires CI but doesn't need a review at the
moment." That is a common use case in Kafka community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
