squah-confluent commented on code in PR #17285: URL: https://github.com/apache/kafka/pull/17285#discussion_r1779753418
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicIds.java: ########## @@ -164,20 +308,20 @@ public boolean equals(Object o) { TopicIds uuids = (TopicIds) o; if (!Objects.equals(topicNames, uuids.topicNames)) return false; - return Objects.equals(image, uuids.image); + return Objects.equals(resolver, uuids.resolver); } @Override public int hashCode() { int result = topicNames.hashCode(); - result = 31 * result + image.hashCode(); + result = 31 * result + resolver.hashCode(); return result; } @Override public String toString() { return "TopicIds(topicNames=" + topicNames + - ", image=" + image + + ", resolver=" + resolver + Review Comment: I'll add a toString implementation that returns `<class name>(image=<image>)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org