junrao commented on code in PR #17380:
URL: https://github.com/apache/kafka/pull/17380#discussion_r1792225329
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -706,6 +712,16 @@ private SharePartitionKey sharePartitionKey(String
groupId, TopicIdPartition top
return new SharePartitionKey(groupId, topicIdPartition);
}
+ /**
+ *
+ * @param groupId The share group id, this is used to identify the share
group.
+ * @param topicIdPartition The topic partition that the group is
subscribed to.
+ * @return The share partition stored for the share group topic-partition.
+ */
+ protected SharePartition fetchSharePartition(String groupId,
TopicIdPartition topicIdPartition) {
Review Comment:
Unlike SharePartition fetchSharePartition(SharePartitionKey
sharePartitionKey), this method can return null. Should all callers check for
null explicitly?
Could we name them differently so that the semantic is clear? Perhaps
`getOrCreateSharePartition` and `sharePartition`?
##########
core/src/main/java/kafka/server/share/DelayedShareFetchGroupKey.java:
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package kafka.server.share;
+
+import kafka.server.DelayedOperationKey;
+
+import org.apache.kafka.common.TopicIdPartition;
+
+import java.util.Objects;
+
+/**
+ * A key for delayed share fetch purgatory that refers to the share partition.
+ */
+public class DelayedShareFetchGroupKey implements DelayedShareFetchKey,
DelayedOperationKey {
+ private final String groupId;
+ private final TopicIdPartition topicIdPartition;
Review Comment:
TopicIdPartition contains both topicId and name. We just need the former in
the key. Ditto for DelayedShareFetchPartitionKey.
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -616,15 +616,21 @@ void maybeProcessFetchQueue() {
});
});
- Set<Object> delayedShareFetchWatchKeys = new HashSet<>();
+ Set<DelayedShareFetchKey> delayedShareFetchWatchKeys = new
HashSet<>();
shareFetchData.partitionMaxBytes().keySet().forEach(
topicIdPartition -> {
- delayedShareFetchWatchKeys.add(new
DelayedShareFetchKey(shareFetchData.groupId(), topicIdPartition));
- delayedShareFetchWatchKeys.add(topicIdPartition);
+ // We add a key corresponding to each share partition in
the request so that when there are
Review Comment:
to each share partition in the request => to each share partition in the
request in the group
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -388,8 +398,7 @@ static class DelayedShareFetchBuilder {
ShareFetchData shareFetchData = mock(ShareFetchData.class);
private ReplicaManager replicaManager = mock(ReplicaManager.class);
private Map<SharePartitionKey, SharePartition> partitionCacheMap = new
HashMap<>();
- private DelayedActionQueue delayedActionsQueue =
mock(DelayedActionQueue.class);
- private DelayedOperationPurgatory<DelayedShareFetch>
delayedShareFetchPurgatory = mock(DelayedOperationPurgatory.class);
+ private SharePartitionManager sharePartitionManager =
mock(SharePartitionManager.class);
Review Comment:
`partitionCacheMap` is unused now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
