[
https://issues.apache.org/jira/browse/KAFKA-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639221#comment-16639221
]
ASF GitHub Bot commented on KAFKA-7476:
---------------------------------------
ewencp closed pull request #5736: KAFKA-7476: Fix Date-based types in
SchemaProjector
URL: https://github.com/apache/kafka/pull/5736
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java
b/connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java
index ea31752f60e..5400705cd10 100644
---
a/connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java
+++
b/connect/api/src/main/java/org/apache/kafka/connect/data/SchemaProjector.java
@@ -160,7 +160,7 @@ private static Object projectPrimitive(Schema source,
Object record, Schema targ
assert source.type().isPrimitive();
assert target.type().isPrimitive();
Object result;
- if (isPromotable(source.type(), target.type())) {
+ if (isPromotable(source.type(), target.type()) && record instanceof
Number) {
Number numberRecord = (Number) record;
switch (target.type()) {
case INT8:
diff --git
a/connect/api/src/test/java/org/apache/kafka/connect/data/SchemaProjectorTest.java
b/connect/api/src/test/java/org/apache/kafka/connect/data/SchemaProjectorTest.java
index 151114e2d29..0db4eecf25c 100644
---
a/connect/api/src/test/java/org/apache/kafka/connect/data/SchemaProjectorTest.java
+++
b/connect/api/src/test/java/org/apache/kafka/connect/data/SchemaProjectorTest.java
@@ -352,6 +352,17 @@ public void testLogicalTypeProjection() throws Exception {
projected = SchemaProjector.project(Timestamp.SCHEMA, 34567L,
Timestamp.SCHEMA);
assertEquals(34567L, projected);
+ java.util.Date date = new java.util.Date();
+
+ projected = SchemaProjector.project(Date.SCHEMA, date, Date.SCHEMA);
+ assertEquals(date, projected);
+
+ projected = SchemaProjector.project(Time.SCHEMA, date, Time.SCHEMA);
+ assertEquals(date, projected);
+
+ projected = SchemaProjector.project(Timestamp.SCHEMA, date,
Timestamp.SCHEMA);
+ assertEquals(date, projected);
+
Schema namedSchema =
SchemaBuilder.int32().name("invalidLogicalTypeName").build();
for (Schema logicalTypeSchema: logicalTypeSchemas) {
try {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SchemaProjector is not properly handling Date-based logical types
> -----------------------------------------------------------------
>
> Key: KAFKA-7476
> URL: https://issues.apache.org/jira/browse/KAFKA-7476
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Reporter: Robert Yokota
> Assignee: Robert Yokota
> Priority: Major
>
> SchemaProjector is not properly handling Date-based logical types. An
> exception of the following form is thrown:
> {{Caused by: java.lang.ClassCastException: java.util.Date cannot be cast to
> java.lang.Number}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
