FrankYang0529 commented on PR #17199: URL: https://github.com/apache/kafka/pull/17199#issuecomment-2402750772
> If that's the case, we'll need to figure out how we can avoid potential synchronization issues. Hi @kirktrue, good catch. There is `synchronized` in `Sensor#recordInternal`. In this case, do we still need a lock in `KafkaConsumerMetrics`? https://github.com/apache/kafka/blob/bb6ebd83f9a0f9b2a37704f1f37b78a48cf480e1/clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java#L230-L244 > I wanted to check in and see if you had any questions or needed anything to progress on this. The PR is almost ready. I will wait to see CI result. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
