apoorvmittal10 commented on PR #17431: URL: https://github.com/apache/kafka/pull/17431#issuecomment-2404451246
> Hey @apoorvmittal10 , thanks for the fix, good catch! > > The fix looks good to me, my only question would be, even though we won't be blocking anymore, we could still end up in a situation where we could be closing the `networkClient`, while still in `TERMINATING_PUSH_NEEDED` state, but without generating the terminal request if there is no call to networkClient.poll. I guess it's ok given that it's the final push but just to double check we don't want any extra effort in sending that last push in some edge cases like this. Yes, we are not that concerned if the final telemetry push doesn't happen. If it happens good else ignore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
