chia7712 commented on code in PR #17353:
URL: https://github.com/apache/kafka/pull/17353#discussion_r1795032707
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1072,12 +1073,10 @@ public Map<TopicPartition, OffsetAndTimestamp>
offsetsForTimes(Map<TopicPartitio
}
try {
- return applicationEventHandler.addAndGet(listOffsetsEvent)
- .entrySet()
- .stream()
- .collect(Collectors.toMap(
- Map.Entry::getKey,
- entry -> entry.getValue().buildOffsetAndTimestamp()));
+ Map<TopicPartition, OffsetAndTimestampInternal> offsets =
applicationEventHandler.addAndGet(listOffsetsEvent);
+ Map<TopicPartition, OffsetAndTimestamp> results = new
HashMap<>(offsets.size());
+ offsets.forEach((k, v) -> results.put(k, v != null ?
v.buildOffsetAndTimestamp() : null));
Review Comment:
> is your suggestion then to remove nulls for both beginningOffsets() and
endOffsets() and offsetsForTimes()` results?
Yes, it's not just my preference—Java 11 (and 4.0 clients) requires using
Java 11, and most collection-related helpers don't accept null values.
I’ll open a JIRA to facilitate more discussion on this. For now, let's keep
this PR focused on aligning the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
