[ https://issues.apache.org/jira/browse/KAFKA-7266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640035#comment-16640035 ]
Stanislav Kozlovski edited comment on KAFKA-7266 at 10/5/18 4:19 PM: --------------------------------------------------------------------- Hey [~lindong], is there any reason this can't go into `2.1.0`? It is in `trunk` since Aug 13 and the `2.1.0` branch isn't cut yet, so I assume it'll be cut from `trunk` and actually go into `2.1.0` by default? was (Author: enether): Hey [~lindong], is there any reason this can't go into `2.1.0`? > Fix MetricsTest test flakiness > ------------------------------ > > Key: KAFKA-7266 > URL: https://issues.apache.org/jira/browse/KAFKA-7266 > Project: Kafka > Issue Type: Improvement > Reporter: Stanislav Kozlovski > Assignee: Stanislav Kozlovski > Priority: Minor > Fix For: 2.2.0 > > > The test `kafka.api.MetricsTest.testMetrics` has been failing intermittently > in kafka builds (recent proof: > https://github.com/apache/kafka/pull/5436#issuecomment-409683955) > The particular failure is in the `MessageConversionsTimeMs` metric assertion - > {code} > java.lang.AssertionError: Message conversion time not recorded 0.0 > {code} > There has been work done previously > (https://github.com/apache/kafka/pull/4681) to combat the flakiness of the > test and while it has improved it, the test still fails sometimes. > h3. Solution > On my machine, the test failed 5 times out of 25 runs. Increasing the record > size and using compression should slow down message conversion enough to have > it be above 1ms. Locally this test has not failed in 200 runs and counting > with those changes -- This message was sent by Atlassian JIRA (v7.6.3#76005)