Linsiyuan9 commented on code in PR #17479:
URL: https://github.com/apache/kafka/pull/17479#discussion_r1797638646
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java:
##########
@@ -153,7 +153,7 @@ public void deserializeOldSubscriptionVersion() {
Subscription subscription = new Subscription(Arrays.asList("foo",
"bar"), null);
ByteBuffer buffer =
ConsumerProtocol.serializeSubscription(subscription, (short) 0);
Subscription parsedSubscription =
ConsumerProtocol.deserializeSubscription(buffer);
- assertEquals(toSet(parsedSubscription.topics()),
toSet(parsedSubscription.topics()));
+ assertEquals(Set.copyOf(parsedSubscription.topics()),
Set.copyOf(parsedSubscription.topics()));
Review Comment:
This should be a wrong unit tests, expect code should be ` assertEquals
(Set) copyOf (subscription. The switchable viewer ()), Set the copyOf
(parsedSubscription. Switchable viewer ())); `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
