showuon commented on code in PR #17506:
URL: https://github.com/apache/kafka/pull/17506#discussion_r1800605403
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -758,8 +758,20 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
}
def effectiveAdvertisedBrokerListeners: Seq[EndPoint] = {
- // Only expose broker listeners
- advertisedListeners.filterNot(l =>
controllerListenerNames.contains(l.listenerName.value()))
+ advertisedListeners.filter(l => {
+ if (!controllerListenerNames.contains(l.listenerName.value())) {
+ true
+ } else if (migrationEnabled &&
Some(l.listenerName.value()).equals(controlPlaneListener.map(_.listenerName.value())))
{
+ // KAFKA-17788: during ZK migration, always include
control.plane.listener.name
+ // in advertisedBrokerListeners.
+ true
+ } else {
+ System.out.println("WATERMELON: migrationEnabled = " +
migrationEnabled )
+ System.out.println("WATERMELON: Some(l) = " + Some(l))
+ System.out.println("WATERMELON: controlPlaneListener = " +
controlPlaneListener)
Review Comment:
Debug log should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
