[
https://issues.apache.org/jira/browse/KAFKA-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643733#comment-16643733
]
ASF GitHub Bot commented on KAFKA-7198:
---------------------------------------
mjsax closed pull request #5763: KAFKA-7198: Enhance KafkaStreams start method
javadoc.
URL: https://github.com/apache/kafka/pull/5763
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
index 5fb89598507..49a701ae8aa 100644
--- a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
+++ b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
@@ -765,6 +765,7 @@ private static HostInfo parseHostInfo(final String
endPoint) {
* This function is expected to be called only once during the life cycle
of the client.
* <p>
* Because threads are started in the background, this method does not
block.
+ * However, if you have global stores in your topology, this method blocks
until all global stores are restored.
* As a consequence, any fatal exception that happens during processing is
by default only logged.
* If you want to be notified about dying threads, you can
* {@link #setUncaughtExceptionHandler(Thread.UncaughtExceptionHandler)
register an uncaught exception handler}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Enhance KafkaStreams start method javadoc
> -----------------------------------------
>
> Key: KAFKA-7198
> URL: https://issues.apache.org/jira/browse/KAFKA-7198
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Bill Bejeck
> Assignee: Kamal Chandraprakash
> Priority: Major
> Labels: newbie
>
> The {{KafkaStreams.start}} method javadoc states that once called the streams
> threads are started in the background hence the method does not block.
> However you have GlobalKTables in your topology, the threads aren't started
> until the GlobalKTables bootstrap fully so the javadoc for the {{start}}
> method should be updated to reflect this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
