frankvicky commented on code in PR #17484:
URL: https://github.com/apache/kafka/pull/17484#discussion_r1802203823


##########
core/src/test/scala/unit/kafka/utils/CoreUtilsTest.scala:
##########
@@ -135,7 +135,7 @@ class CoreUtilsTest extends Logging {
     try {
       Await.result(Future.traverse(1 to count) { _ =>
         Future {
-          CoreUtils.atomicGetOrUpdate(map, 0, {
+          map.getOrElseUpdate(0, {

Review Comment:
   ```
   Benchmark                                                            
(mapSize)  (writePercentage)  Mode  Cnt  Score   Error  Units
   ConcurrentMapBenchmark.testConcurrentHashMapComputeIfAbsentReadOnly        
100                0.1  avgt    5  4.182 ± 0.006  ns/op
   ConcurrentMapBenchmark.testConcurrentHashMapGetReadOnly                    
100                0.1  avgt    5  3.372 ± 0.024  ns/op
   JMH benchmarks done
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to