squah-confluent commented on code in PR #17385: URL: https://github.com/apache/kafka/pull/17385#discussion_r1802515942
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHeterogeneousAssignmentBuilder.java: ########## @@ -157,716 +240,779 @@ public GroupAssignment build() { assignStickyPartitions(); - unassignedPartitionsAssignment(); + computeUnassignedPartitions(unassignedPartitions); Review Comment: The current code looks like ```java Map<Uuid, List<Integer>> unassignedPartitions = computeUnassignedPartitions(); assignRemainingPartitions(unassignedPartitions); ``` What are your thoughts on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org