chia7712 commented on code in PR #17409:
URL: https://github.com/apache/kafka/pull/17409#discussion_r1804026243
##########
gradle/dependencies.gradle:
##########
@@ -47,23 +47,14 @@ if ( !versions.scala.contains('-') ) {
}
// mockito >= 5.5 is required for Java 21 and mockito 5.x requires at least
Java 11
-// mockito 4.11 is used with Java 8 and Scala 2.13
-String mockitoVersion
-if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_11))
- mockitoVersion = "5.10.0"
-else
- mockitoVersion = "4.11.0"
+String mockitoVersion = "5.14.2"
Review Comment:
Could you please add `mockitoVersion` to `versions`?
##########
gradle/dependencies.gradle:
##########
@@ -47,23 +47,14 @@ if ( !versions.scala.contains('-') ) {
}
// mockito >= 5.5 is required for Java 21 and mockito 5.x requires at least
Java 11
-// mockito 4.11 is used with Java 8 and Scala 2.13
-String mockitoVersion
-if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_11))
- mockitoVersion = "5.10.0"
-else
- mockitoVersion = "4.11.0"
+String mockitoVersion = "5.14.2"
// mockito 4.x has two mocking strategies: subclass (mockito-core) and inline
(mockito-inline).
// mockito 5.x has two mocking strategies: inline (mockito-core) and subclass
(mockito-subclass).
// The default strategy (i.e. what `mockito-core` uses) changed to `inline` in
5.x because it works better with newer
// Java versions.
// We always use the `inline` strategy.
-String mockitoArtifactName
-if (mockitoVersion.startsWith("4."))
- mockitoArtifactName = "mockito-inline"
-else
- mockitoArtifactName = "mockito-core"
+String mockitoArtifactName = "mockito-core"
Review Comment:
we don't need this `mockitoArtifactName`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
