chia7712 commented on code in PR #17435: URL: https://github.com/apache/kafka/pull/17435#discussion_r1804027986
########## README.md: ########## @@ -4,8 +4,8 @@ See our [web site](https://kafka.apache.org) for details on the project. You need to have [Java](http://www.oracle.com/technetwork/java/javase/downloads/index.html) installed. -We build and test Apache Kafka with Java 8, 11, 17 and 21. We set the `release` parameter in javac and scalac -to `8` to ensure the generated binaries are compatible with Java 8 or higher (independently of the Java version +We build and test Apache Kafka with 11, 17 and 21. We set the `release` parameter in javac and scalac +to `11` to ensure the generated binaries are compatible with Java 11 or higher (independently of the Java version used for compilation). Java 8 support project-wide has been deprecated since Apache Kafka 3.0, Java 11 support for Review Comment: could you please remove `Java 8 support project-wide has been deprecated since Apache Kafka 3.0` and the link of `[KIP-750](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181308223)`? ########## docs/upgrade.html: ########## @@ -1699,7 +1699,7 @@ <h4><a id="upgrade_2_0_0" href="#upgrade_2_0_0">Upgrading from 0.8.x, 0.9.x, 0.1 <h5><a id="upgrade_200_notable" href="#upgrade_200_notable">Notable changes in 2.0.0</a></h5> <ul> <li><a href="https://cwiki.apache.org/confluence/x/oYtjB";>KIP-186</a> increases the default offset retention time from 1 day to 7 days. This makes it less likely to "lose" offsets in an application that commits infrequently. It also increases the active set of offsets and therefore can increase memory usage on the broker. Note that the console consumer currently enables offset commit by default and can be the source of a large number of offsets which this change will now preserve for 7 days instead of 1. You can preserve the existing behavior by setting the broker config <code>offsets.retention.minutes</code> to 1440.</li> - <li>Support for Java 7 has been dropped, Java 8 is now the minimum version required.</li> + <li>Support for Java 7 and Java 8 has been dropped, Java 11 is now the minimum version required.</li> Review Comment: why you add change to 2.0.0 release? we should update 4.0.0 release, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
