chia7712 commented on code in PR #17520: URL: https://github.com/apache/kafka/pull/17520#discussion_r1804032758
########## tests/README.md: ########## @@ -45,11 +45,11 @@ TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py::StreamsUpgradeT ``` * Run tests with a specific image name ``` -image_name="ducker-ak-openjdk-11" bash tests/docker/run_tests.sh +image_name="ducker-ak-openjdk-17" bash tests/docker/run_tests.sh Review Comment: please align the tag `17.0.2-buster` ########## tests/README.md: ########## @@ -45,11 +45,11 @@ TC_PATHS="tests/kafkatest/tests/streams/streams_upgrade_test.py::StreamsUpgradeT ``` * Run tests with a specific image name ``` -image_name="ducker-ak-openjdk-11" bash tests/docker/run_tests.sh +image_name="ducker-ak-openjdk-17" bash tests/docker/run_tests.sh ``` * Run tests with a different JVM ``` -bash tests/docker/ducker-ak up -j 'openjdk:11'; tests/docker/run_tests.sh +bash tests/docker/ducker-ak up -j 'openjdk:17'; tests/docker/run_tests.sh Review Comment: please align the tag `17.0.2-buster` ########## tests/docker/Dockerfile: ########## @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -ARG jdk_version=openjdk:11 +ARG jdk_version=openjdk:17.0.2-buster Review Comment: Additionally, could you use `openjdk:17-buster` instead? that can point to the latest release ########## tests/docker/Dockerfile: ########## @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -ARG jdk_version=openjdk:11 +ARG jdk_version=openjdk:17.0.2-buster Review Comment: please add comment to the dockerfile ########## tests/docker/ducker-ak: ########## @@ -45,7 +45,7 @@ docker_run_memory_limit="2000m" default_num_nodes=14 # The default OpenJDK base image. -default_jdk="openjdk:11" +default_jdk="openjdk:17.0.2-buster" Review Comment: please align the tag `17.0.2-buster` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
