anshul35 commented on PR #17492:
URL: https://github.com/apache/kafka/pull/17492#issuecomment-2420271846
@kamalcph Please check my previous comment. Do you still want me to add the
UT ?
My approach will be to : Avoid below check in
RemoteLogMetadataManagerTestUtils and inducing initialization failure . Then
inside TopicBasedRemoteLogMetadataManagerTest we can get that
TopicBasedRemoteLogMetadataManager instance and check for initialization failure
assertDoesNotThrow(() ->
TestUtils.waitForCondition(topicBasedRemoteLogMetadataManager::isInitialized,
60_000L,
"Time out reached before it is initialized
successfully"));
Ideally, RemoteLogMetadataManagerTestUtils should have been written in such
as way to allow consumers to test for pre initialization cases as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
