apoorvmittal10 commented on code in PR #17322:
URL: https://github.com/apache/kafka/pull/17322#discussion_r1805391670
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -433,6 +433,7 @@ class BrokerServer(
config.shareGroupConfig.shareGroupDeliveryCountLimit,
config.shareGroupConfig.shareGroupPartitionMaxRecordLocks,
config.shareGroupConfig.shareFetchPurgatoryPurgeIntervalRequests,
+ config.shareGroupConfig.shareFetchMaxFetchRecords(),
Review Comment:
Thanks for pointing, my bad. Done.
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -1209,34 +1352,42 @@ public void testAcquireReleasedRecordMultipleBatches() {
// Fourth fetch request with 5 records starting from offset 28.
MemoryRecords records4 = memoryRecords(5, 28);
- List<AcquiredRecords> acquiredRecordsList = sharePartition.acquire(
+ List<AcquiredRecords> acquiredRecordsList =
fetchAcquiredRecords(sharePartition.acquire(
MEMBER_ID,
+ Integer.MAX_VALUE,
new FetchPartitionData(Errors.NONE, 40, 3, records1,
- Optional.empty(), OptionalLong.empty(), Optional.empty(),
OptionalInt.empty(), false));
+ Optional.empty(), OptionalLong.empty(), Optional.empty(),
OptionalInt.empty(), false)),
+ 5);
assertArrayEquals(expectedAcquiredRecords(records1, 1).toArray(),
acquiredRecordsList.toArray());
assertEquals(15, sharePartition.nextFetchOffset());
- acquiredRecordsList = sharePartition.acquire(
+ acquiredRecordsList = fetchAcquiredRecords(sharePartition.acquire(
MEMBER_ID,
+ Integer.MAX_VALUE,
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
