ShivsundarR opened a new pull request, #17537: URL: https://github.com/apache/kafka/pull/17537
*What* Currently in `ShareConsumeRequestManager`, after we receive a `ShareFetchResponse`, if the subscription changes before we acknowledge(via `ShareFetch`), then we do not acknowledge the records which are not part of the updated subscription. Instead we must acknowledge all the records that we had received irrespective of the current subscription. This bug is only when we are acknowledging via `ShareFetch` where we use `SubscriptionState::fetchablePartitions` to obtain the partitions to fetch. In `ShareAcknowledge`, as we are getting the partitions from the active share sessions, even if the subscription changed, the session would remain active. In future, we would ideally refactor to make the `ShareFetch` also use the active share sessions instead of `SubscriptionState`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
