mimaison commented on PR #17514: URL: https://github.com/apache/kafka/pull/17514#issuecomment-2421616527
They are basically the same. The main difference is that `EndPoint` can be constructed from the listeners config. `RemoteLogManager` does not need that since it's provided an instance, so it's better to use instead `Endpoint` which is part of the public API. My goal is to remove dependencies onto `core` classes so we can move the Java classes under `kafka.log.remote` to the `storage` module eventually. In order to do so the big remaining issue is `Partition`. `RemoteLogManager` uses that class in a few places and it's not a class we can easily move yet. As far as I can tell we use `Partition` to be able to retrieve the log dir (via `partition.log()` in `filterPartitions()`). Maybe we can introduce an interface to decouple this dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
