m1a2st commented on code in PR #17541:
URL: https://github.com/apache/kafka/pull/17541#discussion_r1806524125
##########
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java:
##########
@@ -1209,7 +1209,7 @@ protected SchemaAndValue roundTrip(Schema desiredSchema,
String currentValue) {
}
protected SchemaAndValue roundTrip(Schema desiredSchema, SchemaAndValue
input) {
- String serialized = Values.convertToString(input.schema(),
input.value());
+ String serialized = input != null ?
Values.convertToString(input.schema(), input.value()) : null;
Review Comment:
Why we need this change? It will check `null` value in
`Values.convertToString`.
https://github.com/apache/kafka/blob/6a37d5ccebaa6bbfc1d1b943f0ff761cf978da7d/connect/api/src/main/java/org/apache/kafka/connect/data/Values.java#L219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
