ChengyanOo commented on code in PR #17507:
URL: https://github.com/apache/kafka/pull/17507#discussion_r1808002535
##########
core/src/test/java/kafka/admin/ConfigCommandTest.java:
##########
@@ -1670,80 +1205,6 @@ private ConfigCommand.ConfigCommandOptions
createOpts(String entityType, Optiona
return new ConfigCommand.ConfigCommandOptions(toArray(optArray,
nameArray, otherArgs));
}
- private void checkEntity(String entityType, Optional<String> entityName,
String expectedEntityName, List<String> otherArgs) {
- ConfigCommand.ConfigCommandOptions opts = createOpts(entityType,
entityName, otherArgs);
- opts.checkArgs();
- ConfigCommand.ConfigEntity entity = ConfigCommand.parseEntity(opts);
Review Comment:
Thanks for your review! @chia7712, but parseEntity had already been removed
in this commit, is there anything else I should do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
