bbejeck commented on code in PR #17327:
URL: https://github.com/apache/kafka/pull/17327#discussion_r1809713317
##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -18,34 +18,27 @@
from ducktape.mark.resource import cluster
from ducktape.tests.test import Test
from ducktape.utils.util import wait_until
-from kafkatest.services.kafka import KafkaService
+from kafkatest.services.kafka import KafkaService, quorum
from kafkatest.services.streams import StreamsBrokerCompatibilityService
from kafkatest.services.verifiable_consumer import VerifiableConsumer
-from kafkatest.services.zookeeper import ZookeeperService
-from kafkatest.version import LATEST_1_0, LATEST_1_1, \
- LATEST_2_0, LATEST_2_1, LATEST_2_2, LATEST_2_3, LATEST_2_4, LATEST_2_5,
LATEST_2_6, LATEST_2_7, LATEST_2_8, \
+from kafkatest.version import LATEST_2_8, \
LATEST_3_0, LATEST_3_1, LATEST_3_2, LATEST_3_3, LATEST_3_4, LATEST_3_5,
LATEST_3_6, LATEST_3_7, LATEST_3_8, KafkaVersion
class StreamsBrokerCompatibility(Test):
"""
These tests validates that
- - Streams works for older brokers 0.11 (or newer)
- - Streams w/ EOS-alpha works for older brokers 0.11 (or newer)
- Streams w/ EOS-v2 works for older brokers 2.5 (or newer)
- - Streams fails fast for older brokers 0.10.0, 0.10.2, and 0.10.1
- - Streams w/ EOS-v2 fails fast for older brokers 2.4 or older
Review Comment:
My understanding was that all ZK was going to be completely removed maybe we
can go with this as is and in a follow-up PR revisit and see what needs to be
added back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
