apoorvmittal10 commented on code in PR #17322:
URL: https://github.com/apache/kafka/pull/17322#discussion_r1811354547
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1138,6 +1185,7 @@ private void acquireSubsetBatchRecords(
} finally {
lock.writeLock().unlock();
}
+ return result.size();
Review Comment:
Sorry, I did not understand this comment. The idea is to keep
`acquireSubsetBatchRecords` method to return count of acquired records.
Currently in this method we add result for every offset hence the count is the
size of the result, but going forward we have to address the TODO in the method
which says to batch to contiguous offsets. Once done then result size will not
be same as count, then from this methid we ll specifically return the count of
the acquired records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
