apoorvmittal10 commented on code in PR #17021:
URL: https://github.com/apache/kafka/pull/17021#discussion_r1811538931
##########
build.gradle:
##########
@@ -2638,6 +2638,7 @@ project(':streams') {
testImplementation libs.mockitoCore
testImplementation libs.mockitoJunitJupiter // supports MockitoExtension
testImplementation libs.junitPlatformSuiteEngine // supports suite test
+ testImplementation libs.opentelemetryProto
Review Comment:
@bbejeck This doesn't seems right.
We should use
`org.apache.kafka.shaded.io.opentelemetry.proto.metrics.v1.MetricsData` as
dependency in `KafkaStreamsTelemetryIntegrationTest`. And change `streams`
project dependency in build.gradle from `api project(':clients')` to `api
project(path: ':clients', configuration: 'shadow')`.
I have verified the change by taking your PR and applying the fixes
mentioned above. You need to amend import-control to allow dependency.
Also prease verify the contents of the streams jar as well, regarding what
all is included. You can do so by issuing `jar -tf kafka-streams.jar >
jar_tf_output` (pre and post). Also check the manifest file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
