clarkwtc commented on code in PR #17578:
URL: https://github.com/apache/kafka/pull/17578#discussion_r1811683401


##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -707,7 +708,8 @@ private Optional<Builder<?>> 
createPushRequest(ClientTelemetrySubscription local
             try (MetricsEmitter emitter = new 
ClientTelemetryEmitter(localSubscription.selector(), 
localSubscription.deltaTemporality())) {
                 emitter.init();
                 kafkaMetricsCollector.collect(emitter);
-                payload = createPayload(emitter.emittedMetrics());
+                MetricsData payloadMetricsData = 
createPayload(emitter.emittedMetrics());
+                payload = compressPayload(payloadMetricsData);

Review Comment:
   I got it. I will prove whether this approach is effective.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to