lianetm commented on code in PR #17549:
URL: https://github.com/apache/kafka/pull/17549#discussion_r1814794971
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -95,10 +95,9 @@ public class CommitRequestManager implements RequestManager,
MemberStateListener
private Optional<Integer> lastEpochSentOnCommit;
/**
- * Latest member ID and epoch received via the {@link
#onMemberEpochUpdated(Optional, Optional)},
- * to be included in the OffsetFetch and OffsetCommit requests if
present. This will have
- * the latest values received from the broker, or empty of the member is
not part of the
- * group anymore.
+ * Latest member ID and epoch received via the {@link
MemberStateListener#onMemberEpochUpdated(Optional, String)},
Review Comment:
nit: the concept of "latest member ID received" is confusing now given that
we don't receive it from the broker anymore. Maybe something like "The member
ID and latest epoch..." (used in other places here too, let's fix them all)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
