AndrewJSchofield commented on code in PR #17573:
URL: https://github.com/apache/kafka/pull/17573#discussion_r1815168371


##########
share/src/main/java/org/apache/kafka/server/share/persister/PartitionFactory.java:
##########
@@ -26,7 +26,7 @@
  */
 public class PartitionFactory {
     public static final int DEFAULT_STATE_EPOCH = 0;
-    public static final int DEFAULT_START_OFFSET = 0;
+    public static final int DEFAULT_START_OFFSET = -1;

Review Comment:
   I would just change the name of the constant to "UNINITIALIZED_START_OFFSET".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to