[ 
https://issues.apache.org/jira/browse/KAFKA-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892774#comment-17892774
 ] 

kangning.li commented on KAFKA-17804:
-------------------------------------

[~junrao]  Pardon me, but I still have some questions:  A follower replica 
should always fetch data from leader,  when the leader becomes follower, it 
should check the "delay fetch purgatory" to make the request fail fast.

 

If we do not trigger the check when a replica changes from leader to follower, 
the delay fetch requests on it seems quite awkward.

> optimize ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-17804
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17804
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jun Rao
>            Assignee: kangning.li
>            Priority: Minor
>
> Currently, ReplicaManager.completeDelayedOperationsWhenNotPartitionLeader is 
> called when (1) a replica is removed from the broker and (2) a replica 
> becomes a follower replica and it checks the completion of multiple 
> purgatories.  However, not all purgatories need to be checked in both 
> situations. For example, the fetch purgatory doesn't need to be checked in 
> case (2) since we support fetch from follower now. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to