adixitconfluent commented on code in PR #17539:
URL: https://github.com/apache/kafka/pull/17539#discussion_r1816829826
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -261,6 +263,11 @@ public static RecordState forId(byte id) {
*/
private long endOffset;
+ /**
+ * We maintain the latest fetch offset metadata to estimate the minBytes
requirement more efficiently.
+ */
+ private Optional<LogOffsetMetadata> latestFetchOffsetMetadata;
Review Comment:
I did it because the value can be null, so we thought it would be better to
keep it as Optional
https://github.com/apache/kafka/pull/17539#discussion_r1815520277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
