cmccabe commented on code in PR #17617:
URL: https://github.com/apache/kafka/pull/17617#discussion_r1819375268
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -966,6 +971,7 @@ void deleteTopic(ControllerRequestContext context, Uuid id,
List<ApiMessageAndVe
}
records.add(new ApiMessageAndVersion(new RemoveTopicRecord().
setTopicId(id), (short) 0));
+ log.info("Successfully added RemoveTopicRecord for topic {} with ID
{}", topic.name, id);
Review Comment:
I think what would be useful is logging the full result set. Like, each
topic and the results of the deletion (success, or whatever error message we
got.) If we make this a single log message at INFO it will be much more
efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
