cmccabe commented on code in PR #17604:
URL: https://github.com/apache/kafka/pull/17604#discussion_r1819377099
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -605,6 +605,16 @@ ControllerResult<CreateTopicsResponseData> createTopics(
Map<ConfigResource, Map<String, Entry<OpType, String>>> configChanges =
computeConfigChanges(topicErrors, request.topics());
+ int totalPartitions = 0;
+ for (CreatableTopic topic: request.topics()) {
+ if (topic.numPartitions() > 0) {
+ totalPartitions += topic.numPartitions();
+ }
+ }
+ if (totalPartitions > 10_000) {
Review Comment:
can we use a constant for this (static final, etc. int).
That would also allow us to lock it to the batch size constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
