jolshan commented on code in PR #17402:
URL: https://github.com/apache/kafka/pull/17402#discussion_r1819464298
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -3869,19 +3951,60 @@ private List<TopicPartition>
getPartitionsFromV3Request(AddPartitionsToTxnReques
return
AddPartitionsToTxnRequest.getPartitions(request.data().v3AndBelowTopics());
}
- private void prepareEndTxnResponse(Errors error, final TransactionResult
result, final long producerId, final short epoch) {
- this.prepareEndTxnResponse(error, result, producerId, epoch, false);
- }
+ private void prepareEndTxnResponse(
Review Comment:
Can we maybe put a comment on these methods about what should be used when
and/or find a way to combine them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
