kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1819479502
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1520,6 +1523,9 @@ private Fetch<K, V> pollForFetches(Timer timer) {
return fetch;
}
+ // send any new fetches (won't resend pending fetches)
+ sendFetches(timer);
Review Comment:
> That's the diff I saw and just wanted to understand/align on where the
poll happens: once we trigger sendFetches (blocking), the client.poll will
happen in the background anytime, not controlled by the app thread. Agreed?
Agreed—the background thread is going to move from calling each of the
`RequestManager`’s `poll()` method to `NetworkClient.poll()` method without the
intervention of the application thread.
> If so I'm ok with leaving the log unchanged, understanding it could come
out after the client.poll happened.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
