lianetm commented on code in PR #17463:
URL: https://github.com/apache/kafka/pull/17463#discussion_r1819716407
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1735,6 +1756,10 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
final long currentTimeMs = time.milliseconds();
final List<CoordinatorRecord> records = new ArrayList<>();
+ if (subscribedTopicRegex != null) {
+ groupRegexManager.validateAndRequestEval(groupId,
subscribedTopicRegex);
+ }
Review Comment:
Agreed, made several changes to align.
Regarding where to re-schedule resolution, I thought it could be on the HB,
when `group.hasMetadataExpired()`, so the first HB from any member after
metadata expires would trigger the async refresh (clear all regexes and then
re-eval async, sequentially for all regexes to build up incrementally). It's
wired up there already, doing nothing for now. Will follow-up on that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
