mimaison commented on code in PR #17636:
URL: https://github.com/apache/kafka/pull/17636#discussion_r1822937151
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -93,18 +94,18 @@ class DelayedOperations(topicId: Option[Uuid],
produce: DelayedOperationPurgatory[DelayedProduce],
fetch: DelayedOperationPurgatory[DelayedFetch],
deleteRecords:
DelayedOperationPurgatory[DelayedDeleteRecords],
- shareFetch:
DelayedOperationPurgatory[DelayedShareFetch]) {
+ shareFetch:
DelayedOperationPurgatory[DelayedShareFetch]) extends Logging {
def checkAndCompleteAll(): Unit = {
- val requestKey = TopicPartitionOperationKey(topicPartition)
- CoreUtils.swallow(() -> fetch.checkAndComplete(requestKey), fetch,
Level.ERROR)
- CoreUtils.swallow(() -> produce.checkAndComplete(requestKey), produce,
Level.ERROR)
- CoreUtils.swallow(() -> deleteRecords.checkAndComplete(requestKey),
deleteRecords, Level.ERROR)
+ val requestKey = new TopicPartitionOperationKey(topicPartition)
+ CoreUtils.swallow(() -> fetch.checkAndComplete(requestKey), this,
Level.ERROR)
Review Comment:
Small change here as any error will be logged on the `Partition` logger
instead of the respective `DelayedOperationPurgatory` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
