chia7712 commented on code in PR #17656:
URL: https://github.com/apache/kafka/pull/17656#discussion_r1824927768
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##########
@@ -539,7 +539,7 @@ public void onNewMetadataImage(MetadataImage newImage,
MetadataDelta delta) {
}
private TopicPartition topicPartitionFor(SharePartitionKey key) {
Review Comment:
Is the string representation `String.format("%s:%s:%d", groupId, topicId,
partition)` included by KIP-932? if not, maybe we should add it to the KIP and
json file (`FindCoordinatorRequest`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
